critique
Hi Dandan,
Interesting work! Here is my feedback:
General
- One-sentence-summary, Abstract, Builds on, and Related pages are all stubs. Don't forget to add that content.
- There are grammatical errors throughout the page that make it much harder to read; proofreading is highly recommended.
- It can be useful to readers to highlight important terms (through bold text, for example).
Problem and Issues
- I'm not exactly sure what the problem is that you're trying to solve. There were indications in the previous section, but it should be stated explicitly in this section as well. The text needs to be more clear; proofreading should help with this.
- You state there are no existing algorithms to solve the problem, but that you will compare two algorithms. Did you come up with these algorithms yourself?
- You state "for each user ID t in T stores data in a table..." - who or what is storing the data? Also, user IDs are called t in one sentence and then l in the next. Is there some reason for this distinction? At present, these issues make the section less clear.
- Is your hypothesis that Trail Matching performs better than the other algorithm? It would be good to make it more clear in the organization of the page (eg. have a "Hypothesis" section).
Algorithm 1
- So it seems at this point that the problem to be solved is matching old users with new users; is this correct?
- How is the transformation from T^B to T^C and T^D done?
- You have a T^C_inactive. Should it be T^D_inactive?
Algorithm 2
- In the new tables C and D, you have IP addresses under the heading "IP pattern". Does "pattern" here indicate simply that there are repeated visits? If not, what part of the data indicates the pattern itself?
- I'm having trouble understanding your pseudocode:
- there may be some indentation issues with the for loops
- I'm not seeing arrayActive referenced anywhere inside the algorithm.
- "item" is not very descriptive
- "a" is being used as an element in multiple nested for loops
- where do "itemA" and "itemB" come from, and why are you removing them?
- what is the condition for the second break?
Conclusions and Future Research
- Can you elaborate on how the algorithms have probabilistic aspects?
Hi JordonJohnson,
Thank you very much! Your feedback is so precious for me, and I would definitely add some more details on my page to make it easier to understand and interesting on the next version. And I am still working on different experiments to compare the two algorithms.
Thank you so much again.
Bests, Dandan
DandanWang (talk)